Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[simulate] Support for multi txn in simulated #136

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

[simulate] Support for multi txn in simulated #136

wants to merge 11 commits into from

Conversation

WGB5445
Copy link
Contributor

@WGB5445 WGB5445 commented Mar 13, 2025

Description

Support for multi in simulated trading

Test Plan

examples/simulate_multi_transaction

Related Links

@WGB5445 WGB5445 requested review from gregnazario and a team as code owners March 13, 2025 07:15
gregnazario
gregnazario reviewed Mar 14, 2025
View reviewed changes
Copy link
Contributor

@gregnazario gregnazario left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks generally fine, could we get a unit test for it?

@WGB5445
Copy link
Contributor Author

WGB5445 commented Mar 14, 2025

Looks generally fine, could we get a unit test for it?

Sure, let me add to that.

@WGB5445
Copy link
Contributor Author

WGB5445 commented Mar 14, 2025

It's a bit strange that importing "github.com/aptos-labs/aptos-go-sdk/crypto" causes an error in the Test_Concurrent_Submission test in client_test.

panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x2 addr=0x0 pc=0x102d89404]

goroutine 489 [running]:
github.com/aptos-labs/aptos-go-sdk.concurrentTxnWaiter(0x14001010310, 0x140002e08c0, 0x1400159c030, 0x140015648c0, 0x14000f08610)
        /Users/logan/code/github/aptos-labs/aptos-go-sdk/client_test.go:726 +0xf4
created by github.com/aptos-labs/aptos-go-sdk.Test_Concurrent_Submission in goroutine 284
        /Users/logan/code/github/aptos-labs/aptos-go-sdk/client_test.go:786 +0x3c8
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x2 addr=0x0 pc=0x102d89404]

@gregnazario

@gregnazario
Copy link
Contributor

It's a bit strange that importing "github.com/aptos-labs/aptos-go-sdk/crypto" causes an error in the Test_Concurrent_Submission test in client_test.

panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x2 addr=0x0 pc=0x102d89404]

goroutine 489 [running]:
github.com/aptos-labs/aptos-go-sdk.concurrentTxnWaiter(0x14001010310, 0x140002e08c0, 0x1400159c030, 0x140015648c0, 0x14000f08610)
        /Users/logan/code/github/aptos-labs/aptos-go-sdk/client_test.go:726 +0xf4
created by github.com/aptos-labs/aptos-go-sdk.Test_Concurrent_Submission in goroutine 284
        /Users/logan/code/github/aptos-labs/aptos-go-sdk/client_test.go:786 +0x3c8
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x2 addr=0x0 pc=0x102d89404]

@gregnazario

This is, I think an issue involving not limiting the number of concurrent threads. This can cause it to run out of threads, or if you have other things going on, it can cause other issues. Can be very difficult to debug

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gregnazario gregnazario gregnazario left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@WGB5445 @gregnazario @Ellenp2p